Skip to content

fix(chat): respect threadId in store requests #15613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 6 commits into from
Aug 1, 2025
Merged

fix(chat): respect threadId in store requests #15613

Antreesy merged 6 commits into from
Aug 1, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 1, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image After
Before 2025-08-01_11h36_31

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Antreesy added 5 commits August 1, 2025 11:24
@Antreesy
fix(chat): remove overhead mutations
a8fce8a 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
test(chat): add messages in both stores when processing
0035370 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(chat): respect threadId on server requests
58adeb1 
- message polling should be done without threadId request, so not added there

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(chat): respect threadId on store getters
ad3399e 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(useDocumentTitle): do not throw, when blocks do not exist yet
2ebc106 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy requested a review from DorraJaouad August 1, 2025 09:28
@Antreesy Antreesy self-assigned this Aug 1, 2025
@Antreesy Antreesy force-pushed the fix/noid/block-message-polling--prereq branch from 145ba23 to 453297f Compare August 1, 2025 10:00
DorraJaouad
DorraJaouad reviewed Aug 1, 2025
View reviewed changes
DorraJaouad
DorraJaouad approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go 🦅

@Antreesy Antreesy merged commit 737319d into main Aug 1, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/block-message-polling--prereq branch August 1, 2025 16:36
@Antreesy Antreesy added this to the v22.0.0-beta.1 milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v22.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @DorraJaouad