Skip to content

fix(fullscreen): enable fullscreen in dashboard and fix disabling fullscreen outside conversation #15635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DorraJaouad merged 2 commits into from
Aug 14, 2025
Merged

fix(fullscreen): enable fullscreen in dashboard and fix disabling fullscreen outside conversation #15635

DorraJaouad merged 2 commits into from
Aug 14, 2025

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 5, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Aug 5, 2025
@DorraJaouad DorraJaouad self-assigned this Aug 5, 2025
@DorraJaouad DorraJaouad force-pushed the fix/15615/fullscreen-app branch from 6bb48b1 to 7a8d13e Compare August 6, 2025 08:42
@ShGKme
Copy link
Contributor

ShGKme commented Aug 6, 2025

Seems like some changes are missing in the PR

@DorraJaouad DorraJaouad force-pushed the fix/15615/fullscreen-app branch from 7a8d13e to fa81d2b Compare August 6, 2025 11:13
@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Aug 6, 2025

In terms of functionality?

ShGKme
ShGKme reviewed Aug 7, 2025
View reviewed changes
Antreesy
Antreesy approved these changes Aug 12, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/15615/fullscreen-app branch from 2f79ac7 to 41ffa9a Compare August 12, 2025 12:40
@DorraJaouad DorraJaouad enabled auto-merge August 12, 2025 12:40
@DorraJaouad DorraJaouad force-pushed the fix/15615/fullscreen-app branch from 41ffa9a to 73911b7 Compare August 14, 2025 11:01
@DorraJaouad DorraJaouad merged commit 0aac527 into main Aug 14, 2025
52 checks passed
@DorraJaouad DorraJaouad deleted the fix/15615/fullscreen-app branch August 14, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v22.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Fullscreen hotkey doesn't work on Talk Dashboard

4 participants

@DorraJaouad @ShGKme @Antreesy