Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 6, 2025

☑️ Resolves

  • add spacing between stripe and bottom bar
  • Restore highlighted screen share button when screensharing
  • Add shadow on own video when one-to-one
  • Reduce gap in split button

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
Copy link
Contributor Author

Here I think I added a 16px right and bottom margin and a shadow

@nimishavijay
I added instead 8px spacing to mimize waste of space. I am not sure however about the shadow as there will also be videos of other participants on that stripe. Is it okay to have only shadow on own video?

@nimishavijay
Copy link
Member

8px looks good to me 👍Adding the gap already improved the look. Nice-to-have: Could we add the shadow if there is only your video in the participants stripe? i.e 1on1s and group calls where only 1 other person has joined?

@DorraJaouad DorraJaouad marked this pull request as ready for review August 6, 2025 11:33
@DorraJaouad DorraJaouad requested review from Antreesy and ShGKme August 6, 2025 16:23
@DorraJaouad DorraJaouad force-pushed the fix/noid/follow-up-call-layout-redesign branch from d8c8880 to 1d397a1 Compare August 11, 2025 12:07
@DorraJaouad DorraJaouad force-pushed the fix/noid/follow-up-call-layout-redesign branch from 3216d7f to 7d053c2 Compare August 12, 2025 12:48
@DorraJaouad DorraJaouad enabled auto-merge August 12, 2025 12:48
@DorraJaouad DorraJaouad merged commit 3bb1da3 into main Aug 12, 2025
52 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/follow-up-call-layout-redesign branch August 12, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants