Skip to content

fix(guests): ease display name submission requirement flow #15648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Aug 14, 2025
Merged

fix(guests): ease display name submission requirement flow #15648

Antreesy merged 1 commit into from
Aug 14, 2025

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 7, 2025 •
edited
Loading

☑️ Resolves

  • Setting displayname in media settings was a bit ambiguious as you have to hit enter or click on the arrow button. It is more clear if the displayname is submitted with closing media settings.
  • I don't prefer debounce update because it will interfer with guest welcome window and allow empty submission

IMPORTANT: We don't allow empty name submission

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Aug 7, 2025
@DorraJaouad DorraJaouad self-assigned this Aug 7, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy August 11, 2025 08:23
Antreesy
Antreesy reviewed Aug 11, 2025
View reviewed changes
Antreesy
Antreesy reviewed Aug 12, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/noid/guestname-media-settings branch from 8509930 to 0a0a08b Compare August 12, 2025 12:51
Antreesy
Antreesy reviewed Aug 12, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/noid/guestname-media-settings branch from 0a0a08b to 7cc7f78 Compare August 14, 2025 10:53
@DorraJaouad DorraJaouad force-pushed the fix/noid/guestname-media-settings branch from 7cc7f78 to 7fa33fa Compare August 14, 2025 11:03
@Antreesy Antreesy merged commit bc9dfda into main Aug 14, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/guestname-media-settings branch August 14, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

3. to review feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v22.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@DorraJaouad @Antreesy