Skip to content

fix(ConversationAvatarEditor): fix creating conversation with emoji #15649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Aug 8, 2025
Merged

fix(ConversationAvatarEditor): fix creating conversation with emoji #15649

nickvergessen merged 1 commit into from
Aug 8, 2025

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 7, 2025 •
edited by nickvergessen
Loading

☑️ Resolves

  • Regression from Vue 3 migration. It is mandatory to expose anything used via ref

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Aug 7, 2025
@DorraJaouad DorraJaouad requested a review from ShGKme August 7, 2025 21:18
@DorraJaouad DorraJaouad self-assigned this Aug 7, 2025
nickvergessen
nickvergessen approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it work again

@nickvergessen nickvergessen merged commit 54a9f18 into main Aug 8, 2025
53 checks passed
@nickvergessen nickvergessen deleted the fix/noid/conversation-emoji branch August 8, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@DorraJaouad DorraJaouad

Labels

feature: frontend 🖌️ "Web UI" client regression

Projects

None yet

Milestone

v22.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@DorraJaouad @nickvergessen