Skip to content

chore(deps): bump @nextcloud/eslint-config to v9.0.0-rc.4 #15692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DorraJaouad merged 3 commits into from
Aug 20, 2025
Merged

chore(deps): bump @nextcloud/eslint-config to v9.0.0-rc.4 #15692

DorraJaouad merged 3 commits into from
Aug 20, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 20, 2025

☑️ Resolves

  • bump eslint dependency
  • audit the rest
  • lint files and updat eslint config

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Aug 20, 2025
@Antreesy Antreesy requested a review from DorraJaouad August 20, 2025 10:30
@Antreesy Antreesy self-assigned this Aug 20, 2025
@Antreesy Antreesy added 3. to review feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels Aug 20, 2025
@DorraJaouad DorraJaouad merged commit b1ed621 into main Aug 20, 2025
53 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/nextcloud-eslint branch August 20, 2025 12:24
ShGKme
ShGKme reviewed Aug 22, 2025
View reviewed changes
src/types/index.ts
Comment on lines -147 to -148
export type SignalingSessionPayload =
| InternalSignalingSession
Copy link
Contributor

@ShGKme ShGKme Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

Copy link
Contributor

@ShGKme ShGKme Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like our style more

Copy link
Contributor Author

@Antreesy Antreesy Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too, but I'm afraid, If we disable this rule, it might fire back in some unexpected places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v22.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @ShGKme @DorraJaouad