chore(deps): bump @nextcloud/vue to v9.0.0-rc.6 #15694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
3. to review
feature: frontend 🖌️
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/15684/nextcloud-vue
branch
from
54fd9ac to
d2dddc9
Compare
51 tasks
DorraJaouad
approved these changes
Aug 20, 2025
ShGKme
reviewed
Aug 20, 2025
Comment on lines
+484
to
+513
| .join-call.button-vue--success { | ||
| // Overwrite default button colors for joining call | ||
| --join-call-background-color: var(--color-border-success); | ||
| --join-call-border-color: var(--color-success-text); | ||
| // Do not overwrite for dark theme | ||
| body[data-theme-dark] & { | ||
| --join-call-border-color: var(--color-success-hover); | ||
| } | ||
| @media (prefers-color-scheme: dark) { | ||
| body[data-theme-default] & { | ||
| --join-call-border-color: var(--color-success-hover); | ||
| } | ||
| } | ||
| border-color: var(--join-call-border-color); | ||
| background-color: var(--join-call-background-color); | ||
| color: var(--color-primary-element-text) !important; | ||
| &:hover:not(:disabled) { | ||
| background-color: var(--join-call-border-color); | ||
| } | ||
| } | ||
| .leave-call-actions--split { | ||
| gap: 1px; | ||
| & :deep(.button-vue--error) { | ||
| // Overwrite default button colors for leaving call | ||
| background-color: #FF3333 !important; // Nextcloud 31 --color-error | ||
| color: var(--color-primary-text) !important; | ||
| } |
Contributor
There was a problem hiding this comment.
IMO, with such changes this checklist item should not be skipped...
- 🖌️ Design was reviewed, approved or inspired by the design team
The change reverts 32 design changes and adds hacks with deep styles override.
Contributor
Author
There was a problem hiding this comment.
Given a zero notice period and no aligning with teams from server side, I don't see an issue with reverting changes for call button
Contributor
Author
There was a problem hiding this comment.
But we have time since release is delayed, so cc @nimishavijay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist