Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Follow-up to fix(useGetThreadId): make reactive value more responsive #15704
  • Wait for router navigation to successfully complete before emitting an event seems more reasonable:
    • token and threadId are updated globally according to route
    • navigation can be no longer interrupted
    • all current use cases are side-effects, which are safe to run after navigation:
      • SearchMessageTab, ThreadsTab - change sidebar tab, safe to do after
      • LeftSidebar - leave-join to signaling happens here, but safe to after
      • useGetMessages - defining a context, the place where it's important to do after 🟢

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before | 🏡 After

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things could have been avoided if this was added previously this week

Image

@Antreesy Antreesy merged commit eb8b8df into main Aug 22, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/15704/post-update branch August 22, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants