-
Notifications
You must be signed in to change notification settings - Fork 509
fix(l10n): Remove redundant "Talk" prefix from "Talk home" #15710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DorraJaouad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, checking with @Antreesy as well
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even more sense now as it's visible. I would add a comment for translators, so it's not translated as 'House' or so
Hmm, it seems like comments cannot be placed inside XML tags. I wonder how you would do this? π€ |
I guess nobody tried =) You can extract that to constant, similar to FILTER_LABELS: const HOME_BUTTON_LABEL = t('spreed', 'Home') // TRANSLATORS Some explanation here
setup() {
...
return {
...
HOME_BUTTON_LABEL,
...
} |
Fair enough |
Signed-off-by: kramo <[email protected]>
9f55ad7 to
7bb5f53
Compare
See #15710 (comment) Co-Authored-By: Joas Schilling <[email protected]>
This is just sort of redundant to have there. You are inside Talk :)
ποΈ UI Checklist
πΌοΈ Screenshots / Screencasts
π Checklist