Skip to content

Conversation

@kra-mo
Copy link
Member

@kra-mo kra-mo commented Aug 22, 2025

This is just sort of redundant to have there. You are inside Talk :)

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

🏚️ Before 🏑 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, checking with @Antreesy as well

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more sense now as it's visible. I would add a comment for translators, so it's not translated as 'House' or so

@kra-mo
Copy link
Member Author

kra-mo commented Aug 22, 2025

Even more sense now as it's visible. I would add a comment for translators, so it's not translated as 'House' or so

Hmm, it seems like comments cannot be placed inside XML tags. I wonder how you would do this? πŸ€”

@Antreesy
Copy link
Contributor

I wonder how you would do this? πŸ€”

I guess nobody tried =)

You can extract that to constant, similar to FILTER_LABELS:

const HOME_BUTTON_LABEL = t('spreed', 'Home') // TRANSLATORS Some explanation here

setup() {
...
return {
...
HOME_BUTTON_LABEL,
...
}

@kra-mo
Copy link
Member Author

kra-mo commented Aug 22, 2025

I wonder how you would do this? πŸ€”

I guess nobody tried =)

You can extract that to constant, similar to FILTER_LABELS:

const HOME_BUTTON_LABEL = t('spreed', 'Home') // TRANSLATORS Some explanation here

setup() {
...
return {
...
HOME_BUTTON_LABEL,
...
}

Fair enough

@kra-mo kra-mo force-pushed the fix/redundant-word branch from 9f55ad7 to 7bb5f53 Compare August 22, 2025 14:59
@Antreesy Antreesy changed the title fix(l10n): Remove redundant "Talk" fix(l10n): Remove redundant "Talk" prefix from "Talk home" Aug 22, 2025
@Antreesy Antreesy merged commit dd35b20 into main Aug 22, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/redundant-word branch August 22, 2025 15:49
kra-mo added a commit that referenced this pull request Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants