fix(test): adjust mocks and test helpers #15754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
reviewed
Aug 29, 2025
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.spec.js
Outdated
Show resolved
Hide resolved
Antreesy
force-pushed
the
fix/noid/vitest
branch
from
467a0f8 to
23f6d04
Compare
ShGKme
reviewed
Sep 1, 2025
Comment on lines
+78
to
+81
| provide: { | ||
| [HAS_APP_NAVIGATION_KEY]: () => {}, | ||
| [NC_ACTIONS_CLOSE_MENU]: () => {}, | ||
| }, |
Contributor
There was a problem hiding this comment.
just thinking in loud
Maybe we need to find some workaround here. If it would be non-exported Symbol and not Symbol.for the current workaround wouldn't even work.
An idea I had was to suppress [warn] Vue logs about injection.
Another idea - provide a general test wrapper.
src/components/MessagesList/MessagesGroup/Message/Message.spec.js
Outdated
Show resolved
Hide resolved
ShGKme
approved these changes
Sep 1, 2025
Antreesy
force-pushed
the
fix/noid/fixups--from-tests
branch
from
cb27eff to
d7b0fce
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/vitest
branch
from
23f6d04 to
5136058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🏁 Checklist