Skip to content

fix(vue3): adjust to Vue 3, fix regressions #15769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 5 commits into from
Sep 1, 2025
Merged

fix(vue3): adjust to Vue 3, fix regressions #15769

Antreesy merged 5 commits into from
Sep 1, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 1, 2025 •
edited
Loading

☑️ Resolves

  • Found while fixing tests, extracted for separate review

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image 2025-09-01_10h37_28
Nothing 2025-09-01_10h37_34
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next RC (32) milestone Sep 1, 2025
@Antreesy Antreesy requested a review from DorraJaouad September 1, 2025 08:35
@Antreesy Antreesy self-assigned this Sep 1, 2025
@Antreesy Antreesy changed the title chore: migrate from deprecated import in @nextcloud/files fix(vue3): adjust to Vue 3, fix regressions Sep 1, 2025
miaulalala
miaulalala requested changes Sep 1, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/fixups--from-tests branch from cb8107f to 6a0183f Compare September 1, 2025 09:59
@Antreesy Antreesy requested a review from miaulalala September 1, 2025 09:59
DorraJaouad
DorraJaouad approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First 9 commits are good

@Antreesy
chore: migrate from deprecated import in @nextcloud/files
a3d9a26 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(RoomSelector): adjust to Vue3
150bc2e 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(LeftSidebar): set empty content for threads
73c603b 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(chat): minor fixes
b1538cf 
- don't show current year
- remove extra actions separator
- prevent double emitting from file dialog

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(RightSidebar): minor fixes
d7b0fce 
- fix tab icon size
- scope moderator demote action to users

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/fixups--from-tests branch from cb27eff to d7b0fce Compare September 1, 2025 10:34
@Antreesy Antreesy enabled auto-merge September 1, 2025 10:34
@Antreesy Antreesy merged commit 2965f7c into main Sep 1, 2025
55 checks passed
@Antreesy Antreesy deleted the fix/noid/fixups--from-tests branch September 1, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client regression

Projects

None yet

Milestone

v22.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @miaulalala @DorraJaouad