Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 2, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, my first idea about this feature is to place it in the message buttons menu and integrate in message editing feature when being used on a Thread message.

Given that the chance to insert the input field inside message body has been rejected :/. I would suggest to at least render in the new message input but I am not sure how it should look like.

@nimishavijay
Copy link
Member

nimishavijay commented Sep 3, 2025

I had similar thoughts as @DorraJaouad . We should allow editing the message as well, and if it is possible rn it doesn't seem obvious.

My idea would be to rename it to "edit thread details" (any better wording ideas anyone?) and allow that from 3 points:

  • in the conversation when you are outside a thread, we can have it as an action in the message actions menu, and clicking on that would allow you to edit title and description like how a normal message is edited
  • inside a thread we can have a 3 dot menu in the header, and clicking on that would again allow you edit like a normal message
  • in the list of threads on the left, we can have in the action menu like in this PR, clicking on that would open a modal with title and message which we can edit and save

What are your thoughts?

@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 3, 2025

in the conversation when you are outside a thread, we can have it as an action in the message actions menu, and clicking on that would allow you to edit title and description like how a normal message is edited

  • would be fine to rename existing button for 'Edit message' -> 'Edit thread details' then?

inside a thread we can have a 3 dot menu in the header, and clicking on that would again allow you edit like a normal message
in the list of threads on the left, we can have in the action menu like in this PR, clicking on that would open a modal with title and message which we can edit and save

I'd prefer to unify both with a dialog or popover, whatever fits best. And these two should not affect first message, as it's:

  • can no longer be edited (after 6 hours)
  • is not visible in both these places

@nimishavijay
Copy link
Member

would be fine to rename existing button for 'Edit message' -> 'Edit thread details' then?

Yes, for threads it can be "Edit thread details" and for regular messages "Edit messages" :)

I'd prefer to unify both with a dialog or popover, whatever fits best. And these two should not affect first message

Works for me 👍🏼 we can do a dialog as the message may be long and fitting that into a small popover may not be the best idea.

@Antreesy Antreesy force-pushed the feat/15608/rename-threads-frontend branch from cfd4552 to badf7bd Compare September 3, 2025 12:26
@Antreesy Antreesy force-pushed the feat/15608/rename-threads-frontend branch from badf7bd to f30e8fc Compare September 3, 2025 15:21
@Antreesy Antreesy merged commit 8399da6 into main Sep 3, 2025
55 checks passed
@Antreesy Antreesy deleted the feat/15608/rename-threads-frontend branch September 3, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants