-
Notifications
You must be signed in to change notification settings - Fork 509
fix(thread): support renaming a thread in frontend #15779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a9d7d4 to
cfd4552
Compare
DorraJaouad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, my first idea about this feature is to place it in the message buttons menu and integrate in message editing feature when being used on a Thread message.
Given that the chance to insert the input field inside message body has been rejected :/. I would suggest to at least render in the new message input but I am not sure how it should look like.
|
I had similar thoughts as @DorraJaouad . We should allow editing the message as well, and if it is possible rn it doesn't seem obvious. My idea would be to rename it to "edit thread details" (any better wording ideas anyone?) and allow that from 3 points:
What are your thoughts? |
I'd prefer to unify both with a dialog or popover, whatever fits best. And these two should not affect first message, as it's:
|
Yes, for threads it can be "Edit thread details" and for regular messages "Edit messages" :)
Works for me 👍🏼 we can do a dialog as the message may be long and fitting that into a small popover may not be the best idea. |
cfd4552 to
badf7bd
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
badf7bd to
f30e8fc
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist