Skip to content

fix(threads): show temporary thread starter message, post in thread without replies #15780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 4 commits into from
Sep 4, 2025
Merged

fix(threads): show temporary thread starter message, post in thread without replies #15780

Antreesy merged 4 commits into from
Sep 4, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 2, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • API: Long polling still returns a thread message with parent

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next RC (32) milestone Sep 2, 2025
@Antreesy Antreesy self-assigned this Sep 2, 2025
@Antreesy Antreesy force-pushed the fix/15776/thread-info-frontend branch from 603cbf6 to 351589a Compare September 3, 2025 16:36
@Antreesy Antreesy requested a review from DorraJaouad September 3, 2025 16:36
@Antreesy Antreesy marked this pull request as ready for review September 3, 2025 16:36
@Antreesy Antreesy force-pushed the fix/15776/thread-info-frontend branch from 351589a to 4064cf3 Compare September 4, 2025 07:19
DorraJaouad
DorraJaouad reviewed Sep 4, 2025
View reviewed changes
@nickvergessen
Copy link
Member

nickvergessen commented Sep 4, 2025

Seems to fix the problem with the temporary messages

API: Long polling still returns a thread message with parent

Most likely not going to fix it soon, as we need to clarify if it breaks clients, etc.

@Antreesy Antreesy force-pushed the fix/15776/thread-info-frontend branch from 32d1eb1 to c0d5769 Compare September 4, 2025 08:43
@Antreesy
fix(useTemporaryMessage): refactor composable
f24667f 
- include new params (threadTitle, threadReplies)
- allow post in threads without replying

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(chat): use new thread params on thread starter message
072e780 
- threadTitle, threadReplies

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(chat): show thread starter message for temporary ones
520a67d 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(messagesStore): update thread info from any thread message
ebccdba 
- do not duplicate parallel thread requests

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/15776/thread-info-frontend branch from c0d5769 to ebccdba Compare September 4, 2025 09:44
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 4, 2025

/backport to stable32

@Antreesy Antreesy merged commit 2b86dec into main Sep 4, 2025
55 checks passed
@Antreesy Antreesy deleted the fix/15776/thread-info-frontend branch September 4, 2025 10:55
@backportbot backportbot bot mentioned this pull request Sep 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

2. developing feature: frontend 🖌️ "Web UI" client feature: threads 🧵

Projects

None yet

Milestone

v22.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @nickvergessen @DorraJaouad