Skip to content

fix(threads): prevent submitting a thread without a title #15790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Sep 3, 2025
Merged

fix(threads): prevent submitting a thread without a title #15790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions src/components/NewMessage/NewMessage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,16 @@
class="new-message-form__thread-title"
:label="t('spreed', 'Thread title')"
:disabled="disabled"
:error="!!errorTitle"
:title="errorTitle"
show-trailing-button
@trailing-button-click="setCreateThread(false)" />
<NcRichContenteditable
ref="richContenteditable"
:key="container"
v-model="text"
:class="{ 'new-message-form__input-rich--required': errorTitle }"
:title="errorTitle"
:class="{ 'new-message-form__input-rich--required': errorMessage }"
:title="errorMessage"
:auto-complete="autoComplete"
:disabled="disabled"
:user-data="userData"
Expand Down Expand Up @@ -350,6 +352,7 @@ export default {
return {
text: '',
errorTitle: '',
errorMessage: '',
silentChat: false,
// True when the audio recorder component is recording
isRecordingAudio: false,
Expand Down Expand Up @@ -551,7 +554,7 @@ export default {
},

text(newValue) {
this.errorTitle = ''
this.errorMessage = ''
if (this.currentUploadId && !this.upload) {
return
} else if (this.dialog && this.broadcast) {
Expand All @@ -560,6 +563,10 @@ export default {
this.debouncedUpdateChatInput(newValue)
},

threadTitle(newValue) {
this.errorTitle = ''
},

messageToEdit(newValue) {
if (newValue) {
this.text = this.chatExtrasStore.getChatEditInput(this.token)
Expand Down Expand Up @@ -729,10 +736,20 @@ export default {

if (this.hasText) {
this.text = parseSpecialSymbols(this.text)
} else if (this.threadCreating && !this.hasText) {
// TRANSLATORS Error indicator: do not allow to create a thread without a message text
this.errorTitle = t('spreed', 'Message text is required')
return
}

if (this.threadCreating) {
if (!this.threadTitle) {
// TRANSLATORS Error indicator: do not allow to create a thread without a thread title
this.errorTitle = t('spreed', 'Thread title is required')
}
if (!this.hasText) {
// TRANSLATORS Error indicator: do not allow to create a thread without a message text
this.errorMessage = t('spreed', 'Message text is required')
}
if (this.errorTitle || this.errorMessage) {
return
}
}

// Clear input content from store
Expand All @@ -743,7 +760,7 @@ export default {
const message = this.text.trim()
// Substitute thread title with message text, if missing
const threadTitle = this.threadCreating
? this.threadTitle.trim() || this.text.trim()
? this.threadTitle.trim()
: undefined

const temporaryMessage = this.createTemporaryMessage({
Expand Down