[stable32] Handle partial transcript chunks in live transcriptions #15801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Originally the live_transcription app sent the transcripts once they were definitive, so each transcript could take several seconds to be received until the app was "confident" enough and settled on a text. Now it will send transcripts as soon as possible instead, and a "final" attribute is now included in the signaling message to mark whether a transcript is "frozen" or should be replaced with the next transcript. For backwards compatibility any transcript message without an explicit "final" attribute is seen as final. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Now that the last chunk can be replaced with a different one it is necessary to remove the cached line information for the last known chunk and generate it again, rather than updating the cache from the chunk after the last known one. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Now that the last chunk can be replaced with a different one it could happen that the new one is shorter than the previous one and the total number of lines is reduced. To prevent all the lines from moving down if the last one(s) are removed the "min-height" property now guarantees that the transcript block will not reduce its height even if the number of lines is reduced by forcing it to the largest known height of the element. Nevertheless, the "min-height" property is reset when the whole transcript is resized, as in that case the text is expected to be adjusted to the new size and therefore the number of lines is expected to change. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot
bot
added
3. to review
enhancement
feature: call 📹
Antreesy
approved these changes
Sep 4, 2025
danxuliu
reviewed
Sep 4, 2025
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
I am late to the party, and there was no reason not to, but just in case... tested and works 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15783