fix: Don't transfer sample rooms #15861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
added
feature: api 🛠️
miaulalala
approved these changes
Sep 8, 2025
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
I noticed that
occ talk:user:transfer-ownershipalso transfers sample rooms. We should not do that. At the same time, I wonder if other types should also be excluded here?!Regarding tests, not really sure how to create a sample room easily, as we block it on api level and we currently don't have tests for that.
🏁 Checklist
docs/has been updated or is not required