Skip to content

Conversation

@nickvergessen
Copy link
Member

πŸ› οΈ API Checklist

Starting 1 config at a time, as not all are straight forward to add

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

@nickvergessen nickvergessen added this to the 🍏 Next Major (33) milestone Oct 2, 2025
@nickvergessen nickvergessen self-assigned this Oct 2, 2025
@nickvergessen nickvergessen added 3. to review feature: api πŸ› οΈ OCS API for conversations, chats and participants technical debt labels Oct 2, 2025
@nickvergessen nickvergessen force-pushed the techdebt/noid/introduce-config-lexikon branch from 9526c6d to cbe64d5 Compare October 6, 2025 09:56
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I don't see the Lexicon used anywhere? Is the idea to inject the Lexicon into the IUserConfig later?

@nickvergessen
Copy link
Member Author

Code looks good but I don't see the Lexicon used anywhere? Is the idea to inject the Lexicon into the IUserConfig later?

It's basically implicit. When you use IAppConfig or IUserConfig, and use getBool on something that is registered as Int, it will complain, etc.
Once we added all configs to the lexicon, we can also change the strictness of the lexicon, so it complains when you use a config key that is not defined.

@nickvergessen nickvergessen merged commit b4d95c7 into main Oct 6, 2025
82 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/introduce-config-lexikon branch October 6, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review feature: api πŸ› οΈ OCS API for conversations, chats and participants technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants