Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

handleStartGettingMessagesPreconditions can be called, when:

  • vue-router is ready and all conditions met
  • wacher is triggered and all conditions met

At the time of commiting (21.07.2025) watcher and router were triggered in different order, so everything was working fine. Now second called function cancels server request, which hasn't even started yet, causing it to not appear in the Network tab (yet 'await' for getMessagesContext considered fulfilled)

Solution: early return.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad

This comment was marked as resolved.

@Antreesy
Copy link
Contributor Author

Can we merge them together

Tried, no. if await for router.isReady(), it will replace current route -> replace current token -> trigger watcher again

But also duplicating of if was done before we migrate useGetToken to new logic. so described thing would always happen now, and we don't need that

@Antreesy Antreesy requested a review from ShGKme October 23, 2025 09:22
@Antreesy
Copy link
Contributor Author

/backport to stable32

@Antreesy Antreesy merged commit b13c4d3 into main Oct 23, 2025
56 checks passed
@Antreesy Antreesy deleted the fix/16178/router branch October 23, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants