Skip to content

TEMP: Don't create a transcription failed notification #16356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nickvergessen wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

TEMP: Don't create a transcription failed notification #16356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Service/RecordingService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,10 @@
}

public function notifyAboutFailedTranscript(string $owner, string $roomToken, int $recordingFileId, string $aiType): void {
if ($aiType === 'transcript') {
return;
}

$userFolder = $this->rootFolder->getUserFolder($owner);
$recordingNodes = $userFolder->getById($recordingFileId);

Expand Down Expand Up @@ -346,7 +350,7 @@
->setDateTime($this->timeFactory->getDateTime())
->setObject('recording', $room->getToken())
->setUser($attendee->getActorId())
->setSubject($aiType === 'transcript' ? 'transcript_failed' : 'summary_failed', [

Check failure on line 353 in lib/Service/RecordingService.php

View workflow job for this annotation

GitHub Actions / static-psalm-analysis

ParadoxicalCondition 

lib/Service/RecordingService.php:353:17: ParadoxicalCondition: Condition ($aiType is string(transcript)) contradicts a previously-established condition ($aiType is not string(transcript)) (see https://psalm.dev/089)
'objectId' => $recording->getId(),
]);
$this->notificationManager->notify($notification);
Expand Down
Loading