Skip to content

fix: fullscreen mode with non-default theme #16357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShGKme merged 1 commit into from
Nov 19, 2025
Merged

fix: fullscreen mode with non-default theme #16357

ShGKme merged 1 commit into from
Nov 19, 2025

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 19, 2025

☑️ Resolves

  • Variables are defined on 2 levels:
    1. :root for the default theme
    2. body (via data-theme-x) in a specific theme (light/dark)
  • Level 2 is missing

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added this to the 🍏 Next Major (33) milestone Nov 19, 2025
@ShGKme ShGKme self-assigned this Nov 19, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 19, 2025

/backport to stable32

@ShGKme ShGKme mentioned this pull request Nov 19, 2025
Merged
@ShGKme ShGKme merged commit 423776f into main Nov 19, 2025
56 checks passed
@ShGKme ShGKme deleted the fix/fullscreen branch November 19, 2025 23:00
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 19, 2025

/backport to stable32

2 similar comments
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 19, 2025

/backport to stable32

@Antreesy
Copy link
Contributor

Antreesy commented Nov 20, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Nov 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@ShGKme ShGKme

Labels

3. to review bug

Projects

None yet

Milestone

v23.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ShGKme @Antreesy @DorraJaouad