Skip to content

fix: reduce amount of requests to server during high guests activity #16361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 3 commits into from
Nov 20, 2025
Merged

fix: reduce amount of requests to server during high guests activity #16361

Antreesy merged 3 commits into from
Nov 20, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 20, 2025 •
edited
Loading

☑️ Resolves

  • Fix regressions from guests updates:
    • timeout for failed polling was reset each time, now it's accumulating
    • pass 'is-no-user' to AvatarWrapper to not try to request any data from server
    • get rid of underscore id for no-users avatars
    • store guestUserName in the store and not in parallel components independently

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy
fix(useGetMessages): reset pollingErrorTimeout after successful polling
a8b9a72 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(AvatarWrapper): do not attempt to get avatar from server
5e9f53f 
- guest 'online' would be missing until upstream release

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Nov 20, 2025
@Antreesy Antreesy self-assigned this Nov 20, 2025
@Antreesy Antreesy force-pushed the fix/noid/webinar-guests branch from a2059b6 to c953b3a Compare November 20, 2025 10:38
@Antreesy Antreesy changed the title fix(useGetMessages): reset pollingErrorTimeout after successful polling fix: reduce amount of requests to server during high guests activity Nov 20, 2025
DorraJaouad
DorraJaouad reviewed Nov 20, 2025
View reviewed changes
@Antreesy
fix(SetGuestUsername): set single source of truth for guest input
9b593c6 
- there are two components mounted at the same time

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/webinar-guests branch from c953b3a to 9b593c6 Compare November 20, 2025 11:07
@Antreesy Antreesy merged commit 8072812 into main Nov 20, 2025
56 checks passed
@Antreesy Antreesy deleted the fix/noid/webinar-guests branch November 20, 2025 11:48
@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 20, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Nov 20, 2025
Merged
@Antreesy Antreesy mentioned this pull request Nov 20, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v23.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @DorraJaouad