fix: use array instead of calling the addSelect method #16362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addSelect() calls count and in_array each time it is called, and it also loops through each column. By using the intergrated spread operator for adding select aliases, we can reduce the amount of function calls. Signed-off-by: Anna Larch <[email protected]>
nickvergessen
approved these changes
Nov 20, 2025
nickvergessen
deleted the
fix/noid/use-array-spread-instead-of-method-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addSelect(...$selects)callscount()andin_array()each time it is called, and it also creates aforeachloop for each function call.By using the integrated spread operator for adding select aliases, we can reduce the amount of function calls.
🏁 Checklist
docs/has been updated or is not required