Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix huge amount of poll requests
    • Now schedule an update of results, if was changed, and make an actual request upon dialog opening

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

- Now schedule an update of results, if was changed, and make an actual request upon dialog opening

Signed-off-by: Maksim Sukharev <[email protected]>
Comment on lines +299 to +304
if (this.pollsStore.scheduledPolls[this.token]?.[value]) {
this.pollsStore.getPollData({
token: this.token,
pollId: value,
})
}
Copy link
Contributor

@DorraJaouad DorraJaouad Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are just flushing requests upon opening poll viewer, we will lose the responsive UI when the dialog remains open (which I think it is the case for the polls that are created in the beginning of the webinars like Have you heard about Nextcloud before?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For chat relay, it is a must we get these information when someone votes:

  • Actor who voted
  • The option
  • the poll Id

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For chat relay, it is a must we get these information when someone votes:

  • Actor who voted

Only possible when it's a public poll :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only possible when it's a public poll :/

Yes, we are not even receiving poll_voted for anonymous poll, so if we receive it, it is evident it is a public poll

@Antreesy Antreesy marked this pull request as draft December 11, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants