Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 24, 2025

Backport of #16070

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

```
npm i -D @rspack/cli @rspack/core @rspack/plugin-node-polyfill \
  css-loader sass-loader vue-loader
```

Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
```
npm un @nextcloud/webpack-vue-config \
  babel-loader-exclude-node-modules-except esbuild-loader \
  mini-css-extract-plugin webpack-bundle-analyzer worker-loader
```

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the backport/16070/stable32 branch from 71c94a0 to ea5b70d Compare November 24, 2025 19:09
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
Copy link
Contributor

ShGKme commented Nov 24, 2025

@ShGKme ShGKme marked this pull request as ready for review November 24, 2025 19:13
@Antreesy
Copy link
Contributor

This also differs because it was missing from stable32-Webpack (and working with main-RSPack): #16389
Do we need this to be reverted, or it should also exists on main branch?

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the backport/16070/stable32 branch from f5ddb5c to 273dbc8 Compare November 24, 2025 21:32
@ShGKme
Copy link
Contributor

ShGKme commented Nov 24, 2025

Do we need this to be reverted, or it should also exists on main branch?

We should have __webpack_public_path__ in every entrypoint, so also the main branch.

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works if install npm -D sass. It was previously provided by vue-virtual-scroller

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
Copy link
Contributor

ShGKme commented Nov 25, 2025

@nickvergessen
Copy link
Member

So, someone hit the green button?

@Antreesy Antreesy merged commit 99b16be into stable32 Nov 26, 2025
57 checks passed
@Antreesy Antreesy deleted the backport/16070/stable32 branch November 26, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants