-
Notifications
You must be signed in to change notification settings - Fork 509
feat(pinMessages): add pinned messages to UI #16507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e16bf23 to
f443327
Compare
Member
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Show resolved
Hide resolved
40678e0 to
38a9057
Compare
Antreesy
reviewed
Dec 12, 2025
Antreesy
reviewed
Dec 12, 2025
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
6b64d9c to
43dfc23
Compare
Member
|
Nice! Looks great :) Some small comments and some questions from my side:
|
7ef84f3 to
a56f176
Compare
Antreesy
reviewed
Dec 16, 2025
src/components/RightSidebar/PinnedMessages/PinnedMessageItem.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/PinnedMessages/PinnedMessageItem.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/PinnedMessages/PinnedMessageItem.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/SharedItems/sharedItemsConstants.ts
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
5503172 to
6b57ae7
Compare
Antreesy
previously requested changes
Dec 16, 2025
Contributor
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Outdated
Show resolved
Hide resolved
d60a087 to
5e42e26
Compare
Antreesy
reviewed
Dec 17, 2025
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/PinnedMessages/PinnedMessageItem.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/SharedItems/sharedItemsConstants.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
5e42e26 to
58cc7a1
Compare
Contributor
Author
|
Processed the valid nitpicks mentioned in the previous review. Now I will add the design changes for message that is pinned in the chat |
Antreesy
reviewed
Dec 17, 2025
src/components/RightSidebar/SharedItems/sharedItemsConstants.ts
Outdated
Show resolved
Hide resolved
5138efe to
8f138a3
Compare
Antreesy
approved these changes
Dec 17, 2025
Antreesy
reviewed
Dec 17, 2025
8f138a3 to
dd9557f
Compare
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
dd9557f to
495f7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
Known issues
Still missing:
🏁 Checklist