Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Dec 9, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

New New
Screenshot 2025-12-17 at 14 10 36 image
Screenshot 2025-12-16 at 09 39 30 image
Screenshot 2025-12-16 at 09 41 17 C
image

🚧 Tasks

Known issues

  • max width: chat width
  • Hide system message of system unpinned a message (time-limited pins)
  • expired pinned messages

Still missing:

  • Show pinned messages in shared Items ( for all or only for moderators?)
  • How to restore hidden pinned message?

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🍏 Next Major (33) milestone Dec 9, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy December 9, 2025 18:40
@DorraJaouad DorraJaouad self-assigned this Dec 9, 2025
@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch 2 times, most recently from e16bf23 to f443327 Compare December 10, 2025 10:42
@nickvergessen
Copy link
Member

grafik

🙈

@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch 7 times, most recently from 40678e0 to 38a9057 Compare December 12, 2025 10:14
@DorraJaouad DorraJaouad marked this pull request as ready for review December 12, 2025 10:15
@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch 5 times, most recently from 6b64d9c to 43dfc23 Compare December 15, 2025 08:38
@nimishavijay
Copy link
Member

nimishavijay commented Dec 15, 2025

Nice! Looks great :) Some small comments and some questions from my side:

  • What does "Discard pin" do? It seems unclear to me. Does it remove the pin only for the user? Maybe then we say "Dismiss" instead? We can also rename "Unpin message" to just "Unpin"
  • The "Pinned by admin" when an end date is set is bold, any reason for that? If it is to just differentiate from the second row of text, then we can do maxcontrast for the second row and regular font weight for the first row. Usually in our UI bolding indicates an action (for eg button text) or read status (eg in Mail)
    • just saw that the same visual logic is used for edited messages as well, so it should be changed there too.
  • In the list of pins in the right sidebar, we don't have to show the time, or the year if it's the same year. Instead we can show the person who pinned if possible.

@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch 3 times, most recently from 7ef84f3 to a56f176 Compare December 16, 2025 09:47
@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch 2 times, most recently from 5503172 to 6b57ae7 Compare December 16, 2025 15:07
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How

@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch 2 times, most recently from d60a087 to 5e42e26 Compare December 16, 2025 20:54
@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch from 5e42e26 to 58cc7a1 Compare December 17, 2025 11:41
@DorraJaouad
Copy link
Contributor Author

Processed the valid nitpicks mentioned in the previous review. Now I will add the design changes for message that is pinned in the chat

@Antreesy Antreesy dismissed their stale review December 17, 2025 13:03

Not blocking anymore

@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch 3 times, most recently from 5138efe to 8f138a3 Compare December 17, 2025 13:49
@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch from 8f138a3 to dd9557f Compare December 17, 2025 15:07
@DorraJaouad DorraJaouad force-pushed the feat/3390/pin-messages-frontend branch from dd9557f to 495f7be Compare December 17, 2025 15:09
@DorraJaouad DorraJaouad merged commit e6e0627 into main Dec 17, 2025
56 checks passed
@DorraJaouad DorraJaouad deleted the feat/3390/pin-messages-frontend branch December 17, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📌 Pinned messages

5 participants