Skip to content

[stable31] Fix low frame rate for videos in grid #16518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danxuliu merged 2 commits into from
Dec 11, 2025
Merged

[stable31] Fix low frame rate for videos in grid #16518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdd0795
refactor: Expose spatial and temporal layer settings for simulcast
danxuliu Dec 3, 2025
10adc44
fix: Always use high temporal layer in simulcast
danxuliu Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/CallView/CallView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,12 +781,14 @@ export default {
},

adjustSimulcastQualityForParticipant(callParticipantModel) {
// Always use the high temporal layer, as a low frame rate can look
// bad specially with a low number of participants.
if (this.isGrid) {
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.MEDIUM)
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.MEDIUM, SIMULCAST.HIGH)
} else if (this.sharedDatas[callParticipantModel.attributes.peerId].promoted || this.selectedVideoPeerId === callParticipantModel.attributes.peerId) {
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.HIGH)
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.HIGH, SIMULCAST.HIGH)
} else {
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.LOW)
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.LOW, SIMULCAST.HIGH)
}
},

Expand Down
12 changes: 7 additions & 5 deletions src/utils/webrtc/models/CallParticipantModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ CallParticipantModel.prototype = {

// Set expected state in Peer object.
if (this._simulcastVideoQuality !== undefined) {
this.setSimulcastVideoQuality(this._simulcastVideoQuality)
this.setSimulcastVideoQuality(this._simulcastVideoQuality.spatial, this._simulcastVideoQuality.temporal)
}
if (this._videoBlocked !== undefined) {
this.setVideoBlocked(this._videoBlocked)
Expand Down Expand Up @@ -378,16 +378,18 @@ CallParticipantModel.prototype = {
this.set('videoBlocked', remoteVideoBlocked)
},

setSimulcastVideoQuality(simulcastVideoQuality) {
setSimulcastVideoQuality(simulcastVideoQualitySpatial, simulcastVideoQualityTemporal) {
// Store value to be able to apply it again if a new Peer object is set.
this._simulcastVideoQuality = simulcastVideoQuality
this._simulcastVideoQuality = {
spatial: simulcastVideoQualitySpatial,
temporal: simulcastVideoQualityTemporal,
}

if (!this.get('peer') || !this.get('peer').enableSimulcast) {
return
}

// Use same quality for simulcast and temporal layer.
this.get('peer').selectSimulcastStream(simulcastVideoQuality, simulcastVideoQuality)
this.get('peer').selectSimulcastStream(simulcastVideoQualitySpatial, simulcastVideoQualityTemporal)
},

setSimulcastScreenQuality(simulcastScreenQuality) {
Expand Down
Loading