Skip to content

build(deps): Bump firebase/php-jwt from 7.0.1 to 7.0.2 #16635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

build(deps): Bump firebase/php-jwt from 7.0.1 to 7.0.2 #16635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6d1c41
build(deps): Bump firebase/php-jwt from 7.0.1 to 7.0.2
dependabot[bot] Dec 27, 2025
1e40905
fix(signaling): Fix used curve_name when using ES384
nickvergessen Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ private function ensureSignalingTokenKeys(string $alg): void {

if (str_starts_with($alg, 'ES')) {
$privKey = openssl_pkey_new([
'curve_name' => 'prime256v1',
'curve_name' => $alg === 'ES384' ? 'secp384r1' : 'prime256v1',
Copy link
Member

@nickvergessen nickvergessen Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fancycode Not sure this has any impact on the code you need in the HPB?

From general side, I guess this means we have to regenerate the key on updating when that algorithm is used? Because the generated key is too weak otherwise:

1) OCA\Talk\Tests\php\ConfigTest::testSignalingTicketV2User with data set #0 ('ES384')
DomainException: Provided key is too short

/home/nickv/Nextcloud/33/server/appsbabies/spreed/lib/Vendor/Firebase/JWT/JWT.php:745
/home/nickv/Nextcloud/33/server/appsbabies/spreed/lib/Vendor/Firebase/JWT/JWT.php:274
/home/nickv/Nextcloud/33/server/appsbabies/spreed/lib/Vendor/Firebase/JWT/JWT.php:232
/home/nickv/Nextcloud/33/server/appsbabies/spreed/lib/Config.php:673
/home/nickv/Nextcloud/33/server/appsbabies/spreed/lib/Config.php:491
/home/nickv/Nextcloud/33/server/appsbabies/spreed/tests/php/ConfigTest.php:411

Copy link
Member

@fancycode fancycode Jan 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signaling server should already support these 384 bit keys:
https://github.com/strukturag/nextcloud-spreed-signaling/blob/9ba9256edbdc11c219c6746833c0c9f883cd012e/hub.go#L1474-L1481

I'll try to test the PR the coming days.

'private_key_bits' => 2048,
'private_key_type' => OPENSSL_KEYTYPE_EC,
]);
Expand Down
Loading