Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 7, 2026

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

A B
image image
image image

🚧 Tasks

  • Apply constraints 'on the flight' (during call)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Jan 7, 2026
@Antreesy Antreesy self-assigned this Jan 7, 2026
@Antreesy Antreesy force-pushed the feat/3252/noise-cancellation--default branch from 7b239cf to 3315fcf Compare January 8, 2026 15:08
@Antreesy Antreesy marked this pull request as ready for review January 8, 2026 15:12
@Antreesy Antreesy requested review from ShGKme and danxuliu January 8, 2026 15:12
@Antreesy Antreesy force-pushed the feat/3252/noise-cancellation--default branch from 3315fcf to cc9ae51 Compare January 8, 2026 15:31
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise exactly what I had in mind. 👍

Also nice idea to add the Device checker in those places.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🖌️ Design was reviewed, approved or inspired by the design team

Not a fan of nested modals here, but leaving it to the design

@Antreesy Antreesy force-pushed the feat/3252/noise-cancellation--default branch from 4120e4b to eabb1da Compare January 9, 2026 12:31
@Antreesy Antreesy merged commit 93941b3 into main Jan 9, 2026
57 checks passed
@Antreesy Antreesy deleted the feat/3252/noise-cancellation--default branch January 9, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚙️ Audio options for auto-gain, echo-cancelation and noise-suppression

4 participants