Skip to content

fix(chat-relay): implement fallback polling #16687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Jan 9, 2026
Merged

fix(chat-relay): implement fallback polling #16687

Antreesy merged 1 commit into from
Jan 9, 2026

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 8, 2026 •
edited
Loading

☑️ Resolves

  • track internally the most recent given message id by server per conversation joined session
  • reset between conversation switches
  • if chat-relay is supported, do not poll and listen to signaling messages
  • once per interval (2 minutes) request original messages from server for that period
  • after actual polling, reset interval to 2 minutes

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes, check Network tab

🚧 Tasks

  • Handle error cases?
  • Test federated / normal / during call
    • call_left, call_joined are coming with HPB messages and do not interrupt polling, so no effect here

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Jan 8, 2026
@Antreesy Antreesy requested a review from ShGKme January 8, 2026 16:44
@Antreesy Antreesy self-assigned this Jan 8, 2026
@Antreesy Antreesy added 3. to review feature: signaling 📶 Internal and external signaling backends feature: frontend 🖌️ "Web UI" client labels Jan 8, 2026
@Antreesy Antreesy mentioned this pull request Jan 8, 2026
Open
8 tasks
nickvergessen
nickvergessen approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, time will tell if we are on the right track

@nickvergessen
Copy link
Member

nickvergessen commented Jan 9, 2026

Test federated / normal / during call

  • Switching into and out of a call

@Antreesy
fix(chat-relay): implement fallback polling
05e3d54 
- track internally the most recent given message id by server per conversation joined session
- reset between conversation switches
- if chat-relay is supported, do not poll and listen to signaling messages
- once per interval (2 minutes) request original messages from server for that period
- after actual polling, reset interval to 2 minutes

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/16630/fallback-polling branch from d23a15e to 05e3d54 Compare January 9, 2026 11:22
@Antreesy Antreesy merged commit 24e2e3c into main Jan 9, 2026
57 checks passed
@Antreesy Antreesy deleted the fix/16630/fallback-polling branch January 9, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

3. to review feature: frontend 🖌️ "Web UI" client feature: signaling 📶 Internal and external signaling backends

Projects

None yet

Milestone

v23.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @nickvergessen