Skip to content

fix(vue3): migrate defineEmits to new syntax #16697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 3 commits into from
Jan 12, 2026
Merged

fix(vue3): migrate defineEmits to new syntax #16697

Antreesy merged 3 commits into from
Jan 12, 2026

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 9, 2026

☑️ Resolves

  • Migrate to Vue 3.3 syntax for defineEmits (tuples)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🍏 Next Beta (33) milestone Jan 9, 2026
@Antreesy Antreesy requested a review from ShGKme January 9, 2026 13:42
@Antreesy Antreesy self-assigned this Jan 9, 2026
@Antreesy Antreesy force-pushed the fix/noid/define-emits branch from 3c6f96a to 236e179 Compare January 9, 2026 14:03
ShGKme
ShGKme approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some follow-ups

ShGKme
ShGKme reviewed Jan 9, 2026
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/define-emits branch from d8a54eb to 236e179 Compare January 9, 2026 14:23
@Antreesy Antreesy force-pushed the fix/noid/define-emits branch from 236e179 to f975f19 Compare January 9, 2026 18:46
nickvergessen
nickvergessen reviewed Jan 12, 2026
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/define-emits branch from f975f19 to 8f2a064 Compare January 12, 2026 10:40
@Antreesy Antreesy merged commit 5608d73 into main Jan 12, 2026
57 checks passed
@Antreesy Antreesy deleted the fix/noid/define-emits branch January 12, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review feature: frontend 🖌️ "Web UI" client technical debt

Projects

None yet

Milestone

🍏 Next Beta (33)

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @nickvergessen @ShGKme