fix: show leave call button for guests - #19318
Closed
AmarjeetKushwaha21 wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, directly addresses the reported UI bug, and relies on the existing isInCall signal used throughout the component’s call-button rendering paths.
Pull request overview
Fixes the “Leave call” button visibility for guests in voice rooms by basing it on actual call participation rather than the conversation’s read/write state, aligning the UI with real call connectivity (Issue #18844).
Changes:
- Updated
showLeaveCallButton()to returnisInCallunconditionally (removing theREAD_WRITEgating). - Keeps “Start/Join call” gating unchanged while ensuring “Leave call” is always available when the user is in a call.
File summaries
| File | Description |
|---|---|
src/components/TopBar/CallButton.vue |
Adjusts leave-call button visibility logic to depend only on call state (isInCall). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Antreesy
requested changes
Sep 6, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
The code change is unrelated to the linked issue. Read-write state has nothing to do with voice rooms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Fix #18844
What changed
The Leave Call button was only shown when the conversation was in READ_WRITE state.
Guests in voice rooms can be connected to a call while the conversation is read-only, which prevented them from seeing the Leave Call button.
This change makes the Leave Call button depend on the actual call state instead of the conversation read/write state.
Testing
git diff --check.browserslistas an undeclared dependency.AI