Send media streams in calls only by moderators #3222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The participant call flags are now honoured as media constraints when joining a call. Therefore, now only the media specified in the flags is allowed to be sent (although whether it is sent or not depends on the available media). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
If the participant can not send media or screenshare it is now hidden from the call view. Note that currently it is not possible to know if a guest is a regular guest or a guest moderator, so any type of guest is hidden. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Guests can not fetch the full participant list, so until now the participants store was only populated with the guest itself. However, the conversation data also includes a list of the users (but no guests) in the conversation, so the participants store can be populated with that data. This will make possible to know if a message is sent by a moderator or not. Note that when the external signaling server is used guests can also know which other guests are in the conversation from the participants update signaling message. However, that data is not used to populate the participants store because the conversation data is enough to know the moderators and to keep a consistent behaviour when using the internal and the external signaling servers. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
enhancement
feature: frontend 🖌️
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
modified the milestones:
11.0.0-alpha.1,
💚 Next Major (21),
11.0.0-alpha.2,
💚 Next Alpha (21)
PVince81
reviewed
Feb 10, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
I added a few comments.
Would be good to have a checkbox list to know what's missing.
| } | ||
| } | ||
| const participantIndex = this.$store.getters.getParticipantIndex(this.token, { participant: this.model.attributes.userId }) |
Member
There was a problem hiding this comment.
we have a participant mixin, not sure if we can use it or extend it ?
| }, | ||
| isSendingMediaOrScreensharingAllowed() { | ||
| return this.participant.participantType === PARTICIPANT.TYPE.OWNER |
Member
There was a problem hiding this comment.
deja vu
I wonder if we should move this to a property and let the callview do this check and tell all sub-components what's allowed or not ?
| * provided both audio and video are available. Otherwise only the specified | ||
| * media will be allowed to be sent. | ||
| * | ||
| * Note that the flags are constraints, but not requeriments. Only the specified |
| currentUser = getCurrentUser() | ||
| } | ||
|
|
||
| if (!currentUser || !currentUser.uid) { |
Member
There was a problem hiding this comment.
add comment to clarify that for guest users we need to explicitly fetch the list (the if statement isn't very clear that we're targetting guests)
Member
I guess it makes sense to add this per room. |
4 tasks
Member
Author
|
Closed in favour of #5693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3203
This still needs more work, as currently it applies to all conversations. It should be configurable somehow, and also handled by mobile applications.