Focus message field after upload or sharing file #4266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
added
2. developing
design
enhancement
feature: chat 💬
After starting an upload or sharing a file in the conversation, set the focus back to the message field. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/4242/focus-form-after-upload
branch
from
e70853a to
95847a8
Compare
PVince81
changed the title
marcoambrosini
approved these changes
Oct 9, 2020
Member
Author
|
@nickvergessen is a backport of this interesting as it's a minor UX addition ? |
Member
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After starting an upload or sharing a file, set the focus back to the message field.
focus happens before the upload dialog is closed=> not an issueBUG: when inserting emoji, cursor always appears at the beginning=> abandoning emoji approach for now until the new rich input field is thereTests