Skip to content

Chat previews now expanded with aspect ratio #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PVince81 wants to merge 3 commits into from
Closed

Chat previews now expanded with aspect ratio #4469

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64a2ae9
Chat previews now expanded with aspect ratio
PVince81 Oct 26, 2020
9cfa070
Expand image preview height to 384
PVince81 Oct 26, 2020
e513241
Center the loading spinner
PVince81 Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export default {
},
previewSize: {
type: Number,
default: 128,
default: 384,
},
// In case this component is used to display a file that is being uploaded
// this parameter is used to access the file upload status in the store
Expand Down Expand Up @@ -162,9 +162,9 @@ export default {
}

const previewSize = Math.ceil(this.previewSize * window.devicePixelRatio)
return generateUrl('/core/preview?fileId={fileId}&x={width}&y={height}', {
// expand width but keep a max height
return generateUrl('/core/preview?fileId={fileId}&x=-1&y={height}&a=1', {
fileId: this.id,
width: previewSize,
height: previewSize,
})
},
Expand Down Expand Up @@ -290,14 +290,18 @@ export default {
object-fit: cover;
}

.loading {
display: inline-block;
width: 100%;
margin-left: 32px;
}

.preview {
display: block;
width: 128px;
height: 128px;
display: inline-block;
height: 384px;
}
.preview-64 {
display: block;
width: 64px;
display: inline-block;
height: 64px;
}

Expand All @@ -308,7 +312,6 @@ export default {
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
margin-top: 4px;
}

&:not(.file-preview--viewer-available) {
Expand Down