Fix public page calls #4643
Merged
Fix public page calls #4643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes chat in sidebar for video verification and when chatting about a file from a public link. Signed-off-by: Vincent Petry <[email protected]>
PVince81
added
3. to review
bug
regression
feature: chat 💬
Signed-off-by: Vincent Petry <[email protected]>
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes chat in sidebar for video verification and when chatting about a
file from a public link.
I tried to set "position: relative" for chatView in general but it would then break scrolling during a logged in call, so I went for a more localized solution (for now).
Fixes #4636
Note: the video won't appear in video verification because of that other bug related to "disable grid view in sidebar": #4573