Allow to set default publishing permissions in a conversation #5708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
danxuliu
force-pushed
the
allow-to-set-default-publishing-permissions-in-a-conversation
branch
from
b13af27 to
efa5394
Compare
PVince81
reviewed
Jun 11, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Code looks good so far, happy to see JS tests :-)
| public function updatePublishingPermissions(Room $room, Participant $participant, int $newState): void { | ||
| $attendee = $participant->getAttendee(); | ||
|
|
||
| if ($attendee->getActorType() === Attendee::ACTOR_GROUPS || $attendee->getActorType() === Attendee::ACTOR_CIRCLES) { |
Member
There was a problem hiding this comment.
not sure if ACTOR_EMAILS will pop up here, might be safer to go with an allow list instead of deny list ?
| icon="icon-audio" | ||
| :close-after-click="true" | ||
| @click="grantPublishingPermissions"> | ||
| {{ t('spreed', 'Grant publishing permissions') }} |
Member
There was a problem hiding this comment.
we might need to double check if "publishing permission" is something that users will easily understand.
on the technical level this term is fine though
Member
|
what's missing ? a checkbox list would be nice, just in case someone needs to take over... |
Member
|
The feedback from other teams and useful global stats/options we want to describe and have. |
danxuliu
force-pushed
the
allow-to-set-default-publishing-permissions-in-a-conversation
branch
from
efa5394 to
52f82fe
Compare
This is needed to add other actions in the menu that can be applied also to owners. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
allow-to-set-default-publishing-permissions-in-a-conversation
branch
from
52f82fe to
9d99aa2
Compare
Publishing permissions can be set by moderators or owners on any participant. For now there is a coarse handling of publishing permissions, so it is only possible to grant or revoke all permissions, not each one of the individual permissions. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Only moderators of group and public conversations can set the value. For simplicity, and to avoid chaos if everyone is allowed to publish during a call with a lot of listener-only participants, the value can be set only if there is no active call. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
allow-to-set-default-publishing-permissions-in-a-conversation
branch
from
9d99aa2 to
745067d
Compare
Member
|
I'm closing this in favor of the plan in #6190 (comment) |
nickvergessen
deleted the
allow-to-set-default-publishing-permissions-in-a-conversation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5693
In #5693 publishing permissions can be set for each participant. However, by default all participants have publishing permissions, and they need to be explicitly revoked. This pull request introduces a setting for conversations to define whether everyone or only moderators should be able to publish by default in the conversation.
For now this just contains some commits salvaged from a previous version of #5693, but they might be useful to implement the feature.