Hide participants without publishing permissions in call view #5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
added
2. developing
enhancement
feature: frontend 🖌️
4 tasks
danxuliu
force-pushed
the
hide-participants-without-publishing-permissions-in-call-view
branch
from
842d7ef to
3afdf14
Compare
If the participant can not send media or screenshare it is now hidden from the call view. If there is a single publisher in the call then that publisher would see the empty call view message, as the rest of participants would be hidden. To solve that a dummy participant that just shows a count of all the subscriber-only participants in the call is added to the call view (if there is at least one subscriber-only participant). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Guests can not fetch the full participant list, so the participant store is empty when the current user is a guest. However, guests can fetch the peer data, so now that data is used when the participant data is not available to find out if another participant has publishing permissions or not and hide her if needed in the call view. The peer data is extended with "publishing permissions" and it is also updated on "participantListChanged" events emitted by the signaling, as until now it was updated only if it was required by a Video element but it was not available. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
hide-participants-without-publishing-permissions-in-call-view
branch
from
3afdf14 to
585cb85
Compare
nickvergessen
added
the
feature: meetings 📅
nickvergessen
modified the milestones:
v16.0.0-beta.1,
🚀 Next Beta (26),
🖤 Next Major (27)
Member
|
Raised as an issue in #10676 to follow up on the idea later. |
nickvergessen
deleted the
hide-participants-without-publishing-permissions-in-call-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5693
In certain types of calls where only a few participants are expected to publish media while the rest are just listeners it may be better to hide all those listeners (for example, in a webcast or a presentation). This pull request hides the participants without publishing permissions in the call view, and shows just a dummy participant with how many listeners are currently in the call.
On the other hand, there are other types of calls in which even if most participants do not have publishing permissions it would be better to still show all the participants in the call view (for example, in a company call). Therefore this should be configurable somehow.
I would also be fine closing the pull request and always showing all participants; it was just an idea I had while implementing the publishing permission, but I am not strongly attached to this feature ;-)