Fix concurrency when cancelling lookForNewMessages #5795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching between regular mode and call mode, the two MessagesList view instances are concurrently disturbing each other's lookForNewMessages call. To fix this, we now introduce a requestId for those requests to which we pass in the chatIdentifier, extended by a generated view id. This brings back the old behavior for now. In the future we should look into keeping the polling request and sharing it between the two Vues, which requires some refactoring of the polling logic and timeouts. Signed-off-by: Vincent Petry <[email protected]>
nickvergessen
approved these changes
Jun 18, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Works now, but the console.log is still there twice:
The request has been canceled Object { message: "canceled" }
| import { EventBus } from '../../services/EventBus' | ||
| import LoadingPlaceholder from '../LoadingPlaceholder' | ||
| import ChevronDown from 'vue-material-design-icons/ChevronDown' | ||
| import { uniqueId } from 'lodash' |
Member
There was a problem hiding this comment.
This breaks uploading files, creating folder and deleting either in the files app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching between regular mode and call mode, the two MessagesList
view instances are concurrently disturbing each other's
lookForNewMessages call.
To fix this, we now introduce a requestId for those requests to which we
pass in the chatIdentifier, extended by a generated view id. This brings
back the old behavior for now.
In the future we should look into keeping the polling request and
sharing it between the two Vues, which requires some refactoring of the
polling logic and timeouts.
Fixes #5764