Skip to content

Fix saving sound settings #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Jun 23, 2021
Merged

Fix saving sound settings #5852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/SettingsDialog/SettingsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export default {
this.playSoundsLoading = true
try {
try {
await this.$store.dispatch('setPlaySounds', status)
await this.$store.dispatch('setPlaySounds', !this.playSounds)
} catch (e) {
showError(t('spreed', 'Failed to save sounds setting'))
}
Expand Down
2 changes: 1 addition & 1 deletion src/store/soundsStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const actions = {
* @param {boolean} enabled Whether sounds should be played
*/
async setPlaySounds(context, enabled) {
await setPlaySounds(!context.state.userId, status)
await setPlaySounds(!context.state.userId, enabled)
context.commit('setPlaySounds', enabled)
},
}
Expand Down