Add icons for Mark as read and unread #5893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
changed the title
Pytal
requested review from
Ivansss,
LukasReschke,
PVince81,
blizzz,
danxuliu,
jancborchardt,
julien-nc,
juliusknorr,
marcoambrosini,
nickvergessen and
skjnldsv
skjnldsv
approved these changes
Jun 29, 2021
PVince81
reviewed
Jun 29, 2021
marcoambrosini
requested changes
Jun 29, 2021
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
I don't the unread icon is appropriate, what about eye-off-outline?
nickvergessen
removed request for
Ivansss,
LukasReschke,
danxuliu,
jancborchardt,
julien-nc and
juliusknorr
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
nickvergessen
force-pushed
the
read-unread-icons
branch
from
dc995fd to
d779abd
Compare
Member
|
Moved both to material icons and using outline eye now:
|
Member
|
/backport to stable22 |
marcoambrosini
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5892