Skip to content

Use aac for voice messages #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcoambrosini wants to merge 1 commit into from
Closed

Use aac for voice messages #5898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/NewMessageForm/AudioRecorder/AudioRecorder.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export default {
generateFile() {
this.audioStream.getTracks().forEach(track => track.stop())
if (!this.aborted) {
this.blob = new Blob(this.chunks, { type: 'audio/mpeg-3' })
this.blob = new Blob(this.chunks, { type: 'audio/aac; codecs=mp4a.40.2' })
// Generate file name
const fileName = this.generateFileName()
// Convert blob to file
Expand Down Expand Up @@ -277,7 +277,7 @@ export default {
const today = new Date()
let time = today.getFullYear() + '-' + ('0' + today.getMonth()).slice(-2) + '-' + ('0' + today.getDay()).slice(-2)
time += ' ' + ('0' + today.getHours()).slice(-2) + '-' + ('0' + today.getMinutes()).slice(-2) + '-' + ('0' + today.getSeconds()).slice(-2)
return t('spreed', 'Talk recording from {time} ({conversation})', { time, conversation }) + '.mp3'
return t('spreed', 'Talk recording from {time} ({conversation})', { time, conversation }) + '.m4a'
Copy link
Member

@nickvergessen nickvergessen Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's not marked as a voice message anymore roll eyes

Copy link
Member

@nickvergessen nickvergessen Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also since m4a is not an audio file format, safari doesn't allow playing it in the audio tag.

},
},
}
Expand Down