Fix blocked audio recording preview when Talk is embedded in the sidebar #6107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio recording previews use a blob, so the Content Security Policy must allow media from blobs to be able to play it. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable22.1 |
Member
Author
|
/backport to stable22 |
marcoambrosini
approved these changes
Aug 18, 2021
nickvergessen
approved these changes
Aug 20, 2021
nickvergessen
deleted the
fix-blocked-audio-recording-preview-when-talk-is-embedded-in-the-sidebar
branch
This was referenced Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio recording previews use a blob, so the Content Security Policy must allow media from blobs to be able to play it.
This was not a problem in the main Talk UI, as in that case the Content Security Policy already allowed media from blobs.
How to test
Result with this pull request
The preview dialog is shown and the audio recording can be played.
Result without this pull request
The preview dialog is shown but the audio recording can not be played. Browser console shows an error similar to
The page’s settings blocked the loading of a resource at blob:https://192.168.57.21:8443/5a589af9-ab9f-4e6e-8785-fa3da9684ee7 (“media-src”).