API changes: Blocking users as a user #6440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
added
2. developing
enhancement
feature: api 🛠️
vitormattos
changed the title
vitormattos
changed the title
vitormattos
force-pushed
the
feature/api-blocking-users
branch
2 times, most recently
from
c898c62 to
6464ff3
Compare
Rename endpoint Save block on database Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feature/api-blocking-users
branch
2 times, most recently
from
421c000 to
25ff87d
Compare
Comment on lines
61
to
70
| $qb = $this->db->getQueryBuilder(); | ||
|
|
||
| $qb->delete($this->tableName) | ||
| ->andWhere( | ||
| $qb->expr()->eq('actor_type', $qb->createNamedParameter($entity->getActorType(), Types::STRING)), | ||
| $qb->expr()->eq('actor_id', $qb->createNamedParameter($entity->getActorId(), Types::STRING)), | ||
| $qb->expr()->eq('blocked_type', $qb->createNamedParameter($entity->getBlockedType(), Types::STRING)), | ||
| $qb->expr()->eq('blocked_id', $qb->createNamedParameter($entity->getBlockedId(), Types::STRING)) | ||
| ); | ||
| $qb->executeStatement(); |
Member
There was a problem hiding this comment.
Is this needed? We just always delete based on Id and done?
Contributor
Author
There was a problem hiding this comment.
I don't implemented method to delete by ID, only implemented method to delete using blocked id and blocked type.
Do you think it will be necessary to delete by Id and by blocked id and blocked type?
Teardown to clean integration tests Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feature/api-blocking-users
branch
from
25ff87d to
5eec1ab
Compare
fix method typing return all data on list blocked endpoint Signed-off-by: Vitor Mattos <[email protected]>
Removed cache implementation Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feature/api-blocking-users
branch
from
9bfdcb0 to
09a5ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST /settings/block-userGET /settings/block-userDELETE /settings/block-user@allor@user1close #2513