Skip to content

[stable23] Don't "End meeting" when onclick event is the all parameter :P #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoambrosini merged 1 commit into from
Nov 12, 2021
Merged

[stable23] Don't "End meeting" when onclick event is the all parameter :P #6484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/components/TopBar/CallButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<button v-else-if="showLeaveCallButton && !canEndForAll"
class="top-bar__button error"
:disabled="loading"
@click="leaveCall">
@click="leaveCall(false)">
<span
class="icon"
:class="leaveCallIcon" />
Expand Down Expand Up @@ -262,19 +262,25 @@ export default {
this.loading = false
},

async leaveCall(all = false) {
console.info('Leaving call')
async leaveCall(endMeetingForAll = false) {
if (endMeetingForAll) {
console.info('End meeting for everyone')
} else {
console.info('Leaving call')
}

// Remove selected participant
this.$store.dispatch('selectedVideoPeerId', null)
this.loading = true

// Open navigation
emit('toggle-navigation', {
open: true,
})
await this.$store.dispatch('leaveCall', {
token: this.token,
participantIdentifier: this.$store.getters.getParticipantIdentifier(),
all,
all: endMeetingForAll,
})
this.loading = false
},
Expand Down