Skip to content

[stable23] Reduce the bluring so it's not "You on a single color" and disable by default #6535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Nov 17, 2021
Merged

[stable23] Reduce the bluring so it's not "You on a single color" and disable by default #6535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7983c5e
Reduce the bluring so it's not "You on a single color"
nickvergessen Nov 17, 2021
56b670f
Disable background blur by default due to it's performance impact
nickvergessen Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/DeviceChecker/DeviceChecker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ export default {
if (newValue) {
this.audioOn = !localStorage.getItem('audioDisabled_' + this.token)
this.videoOn = !localStorage.getItem('videoDisabled_' + this.token)
this.blurOn = !localStorage.getItem('virtualBackgroundDisabled_' + this.token)
this.blurOn = !!localStorage.getItem('virtualBackgroundEnabled_' + this.token)

this.initializeDevicesMixin()
} else {
Expand Down Expand Up @@ -357,10 +357,10 @@ export default {

toggleBlur() {
if (!this.blurOn) {
localStorage.removeItem('virtualBackgroundDisabled_' + this.token)
localStorage.setItem('virtualBackgroundEnabled_' + this.token, 'true')
this.blurOn = true
} else {
localStorage.setItem('virtualBackgroundDisabled_' + this.token, 'true')
localStorage.removeItem('virtualBackgroundEnabled_' + this.token)
this.blurOn = false
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/utils/media/pipeline/VirtualBackground.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export default class VirtualBackground extends TrackSinkSource {

const virtualBackground = {
type: VIRTUAL_BACKGROUND_TYPE.NONE,
blurValue: 32,
blurValue: 10,
}
const options = {
...isSimd ? segmentationDimensions.model144 : segmentationDimensions.model96,
Expand Down
2 changes: 1 addition & 1 deletion src/utils/webrtc/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ async function signalingJoinCall(token, flags) {
// it should be saved now.
const enableAudio = !localStorage.getItem('audioDisabled_' + token)
const enableVideo = !localStorage.getItem('videoDisabled_' + token)
const enableVirtualBackground = !localStorage.getItem('virtualBackgroundDisabled_' + token)
const enableVirtualBackground = !!localStorage.getItem('virtualBackgroundEnabled_' + token)

const startCallOnceLocalMediaStarted = (configuration) => {
webRtc.off('localMediaStarted', startCallOnceLocalMediaStarted)
Expand Down
4 changes: 2 additions & 2 deletions src/utils/webrtc/models/LocalMediaModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ LocalMediaModel.prototype = {
throw new Error('WebRtc not initialized yet')
}

localStorage.removeItem('virtualBackgroundDisabled_' + this.get('token'))
localStorage.setItem('virtualBackgroundEnabled_' + this.get('token'), 'true')

this._webRtc.enableVirtualBackground()
},
Expand All @@ -415,7 +415,7 @@ LocalMediaModel.prototype = {
throw new Error('WebRtc not initialized yet')
}

localStorage.setItem('virtualBackgroundDisabled_' + this.get('token'), 'true')
localStorage.removeItem('virtualBackgroundEnabled_' + this.get('token'))

this._webRtc.disableVirtualBackground()
},
Expand Down