Skip to content

[stable23] Fix connection warning positioning #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Nov 18, 2021
Merged

[stable23] Fix connection warning positioning #6548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 41 additions & 43 deletions src/components/CallView/shared/LocalMediaControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,41 @@
<div v-shortkey.push="['space']"
@shortkey="handleShortkey">
<div class="buttons-bar">
<div class="network-connection-state">
<Popover
v-if="qualityWarningTooltip"
:boundaries-element="boundaryElement"
:aria-label="qualityWarningAriaLabel"
trigger="hover"
:auto-hide="false"
:open="showQualityWarningTooltip">
<NetworkStrength2Alert
slot="trigger"
decorative
fill-color="#e9322d"
title=""
:size="24"
@mouseover="mouseover = true"
@mouseleave="mouseover = false" />
<div class="hint">
<span>{{ qualityWarningTooltip.content }}</span>
<div class="hint__actions">
<button
v-if="qualityWarningTooltip.action"
class="primary hint__button"
@click="executeQualityWarningTooltipAction">
{{ qualityWarningTooltip.actionLabel }}
</button>
<button
v-if="!isQualityWarningTooltipDismissed"
class="hint__button"
@click="dismissQualityWarningTooltip">
{{ t('spreed', 'Dismiss') }}
</button>
</div>
</div>
</Popover>
</div>
<div id="muteWrapper">
<button
id="mute"
Expand Down Expand Up @@ -212,41 +247,6 @@
</ActionButton>
</Actions>
</div>
<div class="network-connection-state">
<Popover
v-if="qualityWarningTooltip"
:boundaries-element="boundaryElement"
:aria-label="qualityWarningAriaLabel"
trigger="hover"
:auto-hide="false"
:open="showQualityWarningTooltip">
<NetworkStrength2Alert
slot="trigger"
decorative
fill-color="#e9322d"
title=""
:size="24"
@mouseover="mouseover = true"
@mouseleave="mouseover = false" />
<div class="hint">
<span>{{ qualityWarningTooltip.content }}</span>
<div class="hint__actions">
<button
v-if="qualityWarningTooltip.action"
class="primary hint__button"
@click="executeQualityWarningTooltipAction">
{{ qualityWarningTooltip.actionLabel }}
</button>
<button
v-if="!isQualityWarningTooltipDismissed"
class="hint__button"
@click="dismissQualityWarningTooltip">
{{ t('spreed', 'Dismiss') }}
</button>
</div>
</div>
</Popover>
</div>
</div>
</template>

Expand Down Expand Up @@ -907,6 +907,8 @@ export default {
@import '../../../assets/variables.scss';

.buttons-bar {
display: flex;
align-items: center;
button, .action-item {
vertical-align: middle;
}
Expand Down Expand Up @@ -990,14 +992,6 @@ export default {
background: linear-gradient(0deg, gray, white 36px);
}

.network-connection-state {
position: absolute;
bottom: 3px;
right: 12px;
width: 32px;
height: 32px;
}

.hint {
padding: 12px;
max-width: 300px;
Expand All @@ -1022,4 +1016,8 @@ export default {
background-color: transparent;
}
}

::v-deep .trigger {
display: flex;
}
</style>