-
Notifications
You must be signed in to change notification settings - Fork 509
Disconnect received videos when not needed #6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nickvergessen
merged 10 commits into
master
from
disconnect-received-videos-when-not-needed
Apr 28, 2022
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4b3e824
Do not force reconnect when negotiation is needed for receiver peer
danxuliu c313e70
Fix expected simulcast levels not set again when resetting a receiver
danxuliu 48a74da
Update connections rather than create new ones on "negotiationneeded"
danxuliu 34d0084
Make possible to block the video of a receiver peer
danxuliu 5cb20b9
Add tests for UI feedback on connection status of remote participants
danxuliu bbb1783
Refactor "isNotConnected()" to "isConnected()"
danxuliu 6c002a6
Do not show the video as disconnected while updating the connection
danxuliu 4063922
Add helper class to block a remote video when not needed
danxuliu 114b83d
Use RemoteVideoBlocker in call view
danxuliu 4e4ff9b
Handle toggling video on and off directly in the bottom bar
danxuliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /** | ||
| * Basic "attachmediastream" implementation without using "webrtc-adapter", as | ||
| * "browserDetails" is null in unit tests. | ||
| * | ||
| * @param {MediaStream} stream the stream to attach | ||
| * @param {HTMLElement} element the element to attach the stream to | ||
| * @param {object} options ignored | ||
| */ | ||
| export default function(stream, element, options) { | ||
| if (!element) { | ||
| element = document.createElement(options.audio ? 'audio' : 'video') | ||
| } | ||
|
|
||
| element.srcObject = stream | ||
|
|
||
| return element | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.