Skip to content

Try setting only full group by option integration #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Mar 22, 2022
Merged

Try setting only full group by option integration #7032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b9fbbd
Run on MySQL as a test
nickvergessen Mar 21, 2022
45c8b74
Set MySQL ONLY_FULL_GROUP_BY config
nickvergessen Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .drone.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ local Pipeline(test_set, database, services) = {
"stable*"
],
event: (
if database == "sqlite" then ["pull_request", "push"] else ["push"]
if database == "mysql" then ["pull_request", "push"] else ["push"]
)
}
};
Expand Down Expand Up @@ -77,7 +77,8 @@ local PipelineMySQL(test_set) = Pipeline(
command: [
"--innodb_large_prefix=true",
"--innodb_file_format=barracuda",
"--innodb_file_per_table=true"
"--innodb_file_per_table=true",
"--sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION"
],
tmpfs: [
"/var/lib/mysql"
Expand Down
27 changes: 18 additions & 9 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -56,7 +55,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -86,7 +84,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -117,7 +114,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -148,7 +144,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -178,7 +173,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -208,7 +202,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -238,7 +231,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down Expand Up @@ -268,7 +260,6 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -280,6 +271,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -311,6 +303,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -322,6 +315,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -353,6 +347,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -364,6 +359,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -395,6 +391,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -406,6 +403,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -438,6 +436,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -449,6 +448,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -481,6 +481,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -492,6 +493,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -523,6 +525,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -534,6 +537,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -565,6 +569,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -576,6 +581,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -607,6 +613,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand All @@ -618,6 +625,7 @@ services:
- --innodb_large_prefix=true
- --innodb_file_format=barracuda
- --innodb_file_per_table=true
- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION
environment:
MYSQL_DATABASE: oc_autotest
MYSQL_PASSWORD: owncloud
Expand Down Expand Up @@ -649,6 +657,7 @@ trigger:
- master
- stable*
event:
- pull_request
- push
---
kind: pipeline
Expand Down