Add integration tests for notifications

[nickvergessen]

Signed-off-by: Joas Schilling [email protected]

[danxuliu]

Rather than installing the notifications app only in Drone I would add:

NOTIFICATIONS_BRANCH="master"

# Add Notifications app to the parent directory of "spreed" (unless it is
# already there or in "apps").
if [ ! -e "${ROOT_DIR}/apps/notifications" ] && [ ! -e "../../../notifications" ]; then
       (cd ../../../ && git clone --depth 1 --branch ${NOTIFICATIONS_BRANCH} https://github.com/nextcloud/notifications)
fi

to the run.sh file to ensure that the notifications app is installed if needed, no matter if the integration tests are run in Drone, by directly calling ./run.sh or in Docker with ./run-docker.sh.

[nickvergessen]

We do it like this with guests app too atm

[nickvergessen]

Added installing of both apps in run.sh and added another check for additional app directories

[danxuliu]

Other than the comments, 👍

I have added a fixup to remove resetting the current user in user :user has the following notifications, as it is not needed and inconsistent with the rest of steps that get the user as a parameter, and another fixup to simplify cloning the needed apps, as it should not be needed to manually check the paths if app:getpath returned false.

[danxuliu]

The other queries are not guarded against exceptions, should they be guarded too or they will always succeed and this one has something special that could cause the query to throw in some cases?

[nickvergessen]

This one is guarded as it is against the table of another app and I thought better save then annoyed

[danxuliu]

I would say that everything before sending the message should be a precondition, and therefore the steps should be prefixed by Given and And (here and in all the scenarios of this file), but I guess that is just a matter of taste :-)