Skip to content

Conversation

@vitormattos
Copy link
Contributor

@vitormattos vitormattos commented Apr 6, 2022

Background

I used rector to do this big refactor with this code on rector.php:

return static function (ContainerConfigurator $containerConfigurator): void {
	$parameters = $containerConfigurator->parameters();
	$parameters->set(Option::PATHS, [
		__DIR__ . '/lib',
		__DIR__ . '/tests/php',
	]);

	$parameters->set(Option::BOOTSTRAP_FILES, [
		__DIR__ . '/vendor/autoload.php',
		__DIR__ . '/../../lib/composer/autoload.php',
		__DIR__ . '/../../3rdparty/autoload.php',
	]);

	$parameters->set(Option::AUTO_IMPORT_NAMES, true);
	$parameters->set(Option::IMPORT_SHORT_CLASSES, false);

	$services = $containerConfigurator->services();
	$services->set(TypedPropertyRector::class)
		->configure([
			TypedPropertyRector::INLINE_PUBLIC => true,
		]);
};

I don't versioned this code (implementation of rector) because I think is very specific to do refactors, but is a good point to check if is necessary version.

Steps

  • Fix the problems identified on PHPUnit.
  • Fix phpcs issues
  • Fix psalm issues 94c29af

Close #7079

@vitormattos vitormattos added 2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants standardisation labels Apr 6, 2022
@vitormattos vitormattos added this to the 💖 Next Patch (23) milestone Apr 6, 2022
@vitormattos vitormattos self-assigned this Apr 6, 2022
@vitormattos vitormattos marked this pull request as draft April 6, 2022 15:55
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos marked this pull request as ready for review April 6, 2022 22:21
@nickvergessen nickvergessen merged commit 1c09388 into master Apr 7, 2022
@nickvergessen nickvergessen deleted the feature/7079/property-typehinting-where-possible branch April 7, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants standardisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use PHP7.4 property typehinting where possible

3 participants